-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate postgresql.py #985
Conversation
@TG1999 I've just committed and pushed my latest code (still a w-i-p) with updates to
|
@TG1999 Note that I am separating the individual packages ( |
@TG1999 I have been unable to find any licensing information on the PostgreSQL security pages. The primary license reference is at https://www.postgresql.org/about/licence/, which identifies the applicable license as "the PostgreSQL License", with a link to https://www.opensource.org/licenses/postgresql. By its terms, this license covers "this software and its documentation", which could be interpreted to include security-related information within the definition of "documentation". That is the approach I am taking, subject to your input and input from other colleagues. Accordingly, I have updated the license-related info near the top of
|
1995fee
to
f14e5c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
@johnmhoran the changes look good to me, please add a CHANGELOG entry for same. |
@TG1999 On my local branch
In the
Do I add the changelog entry (e.g., |
@johnmhoran please do this. |
f14e5c5
to
20e61f3
Compare
@TG1999 Updated/pushed as discussed -- all GH checks have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. See a comment inlined.
vulnerabilities/models.py
Outdated
# when there are 2 packages one with qualifiers and one without | ||
# qualifiers, having all other fields same, this raises MultipleObjectsReturned | ||
# so we are filling out the fields with empty value to avoid this | ||
for field in PackageURL._fields: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand what you are trying to do with this change. Can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when there are 2 packages one with qualifiers and one without qualifiers. For say pkg:generic/postgres?foo=bar
and one package pkg:generic/postgres
. So when we try to get
second package using (type="generic", name="postgres"), it returns 2 packages which raises MultipleObjectsReturned
. By declaring qualifiers as an empty dict, we only get the package that doesn't have qualifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 this should not be part of this PR. And I am not sure that problem and the fix are correct
Reference: #969 Signed-off-by: John M. Horan <[email protected]>
Reference: #969 Signed-off-by: John M. Horan <[email protected]>
Reference: #969 Signed-off-by: John M. Horan <[email protected]>
Reference: #969 Signed-off-by: John M. Horan <[email protected]>
Reference: #969 Signed-off-by: John M. Horan <[email protected]>
Fixed get_or_create_from_purl Signed-off-by: Tushar Goel <[email protected]>
Reference: #969 Signed-off-by: John M. Horan <[email protected]>
Reference: #969 Signed-off-by: John M. Horan <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
e000171
to
bf048be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you ++ ... I am merging now.
This likely needs a small adjustment for the new CVSS processing |
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Thanks @johnmhoran for your PR, I have regen the tests and all tests are passing now. |
Reference: #969